Conversation
clue
reviewed
Mar 21, 2024
yadaiio
force-pushed
the
Improve_documentation
branch
from
d7d7704 to
3f5d1bd
Compare
yadaiio
force-pushed
the
Improve_documentation
branch
from
3f5d1bd to
719f379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #12 and #22.
References: clue/reactphp-tar#20, clue/reactphp-redis#117, clue/reactphp-shell#20 and clue/reactphp-sqlite#43.
As I saw the link was currently broken in line 117 as we were referring to the PHP 5.4 features, I decided to write a ticket to the maintainers of the documentation page of PHP for asking if this was intentionally, see php/doc-en#3280. They confirmed it and gave me another link. I chose to use this as a reference here. WDYT about this @clue ?
The officially announcement of making this decision for PHP 5+ can be read here: https://www.php.net/manual/php5.php